Gallery dataset redesign #2761
Gallery dataset redesign #2761
Conversation
…ebknossos into gallery-dataset-redesign
…re still unsupported
…css properties that were added before
There was a problem hiding this comment.
The responsive design works very well 👍 Unfortunately, the right hand side of the cards does not render properly for me (chrome & firefox). It looks like this for me:
The horizontal scrollbar shouldn't be there and the text is a bit scrambled. Does it work for your computer @MichaelBuessemeyer ? Maybe you forgot to push some changes?
Also, you need to update the snapshots since you changed the dashboard. You can read this wiki section for details. Just ask me if you have questions! However, you can wait with this until everything else is resolved :)
| @@ -158,3 +162,7 @@ const mapStateToProps = (state: OxalisState): StateProps => ({ | |||
| }); | |||
|
|
|||
| export default connect(mapStateToProps)(GalleryDatasetView); | |||
|
|
|||
| // TODO: mit mediaquery bei kleinen Bildschirmen: display: block; und breite beider spans auf 100% setzen !!! | |||
There was a problem hiding this comment.
What's up with this todo? :) Still relevant?
| background: rgba(0, 0, 0, 0.8); | ||
| display: inline-block; | ||
| .spotlight-item-card { | ||
| height: 300px; |
There was a problem hiding this comment.
Why is the height 300px when we request a height of 400px from the server? Shouldn't we request 300px then?
There was a problem hiding this comment.
Because if the width is below 600px the thumbnails is displayed in full width. If you subtract padding and all you get a max width of 512px that is about 500px.
| } | ||
| } | ||
|
|
||
| .dataset-description-body{ //TODO set the hight of the body correct and let it appear below the heading/title |
|
|
||
|
|
||
| .dataset-thumbnail { | ||
| height: 100%; |
There was a problem hiding this comment.
The indentation is a bit off here. If you use sublime, the package JsPrettier should also format less files for you if you want to save yourself some trouble :)
…ebknossos into gallery-dataset-redesign
Mailable description of changes:
URL of deployed dev instance (used for testing):
Steps to test:
Issues: