Ensure that extra buckets and fallback buckets are loaded with lower priority #2724
Conversation
| const bucketAddress = ((topLeftBucket.slice(): any): Vector4); | ||
| bucketAddress[u] = x; | ||
| bucketAddress[v] = y; | ||
| bucketAddress[w] += wSliceOffset; | ||
|
|
||
| const bucket = binary.cube.getOrCreateBucket(bucketAddress); | ||
| const isExtraBucket = |
There was a problem hiding this comment.
I can't think of a more elegant way to express the logic for the "extra" bucket (better naming needed, too ^^).
There was a problem hiding this comment.
What do you think about simply using the Chebyshev distance instead of the manhattan distance to assign priorities for the priority queue? I feel like this would reduce complexity and avoid the need to take special care of the "extra" buckets :)
There was a problem hiding this comment.
That would indeed solve the problem. However, we would change the loading behavior (from the user's point of view) quite a bit 🤔 Not sure whether that's ok..
There was a problem hiding this comment.
I can't remember what the conclusion of our discussion about this yesterday was 🙈
There was a problem hiding this comment.
I think we said that the priority here doesn't really matter as the ping strategy takes precedence, anyway. However, it's good to leave this edge case in the code because the code might make the ping strategy obsolete at some point (and then it's important). I wouldn't switch to chebyshev without having the approval from the lab..
philippotto
changed the title
philippotto
changed the title
…ket-loading-speed-test
Mailable description of changes:
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
Ready for review
Waiting for lab approval