Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve warning-toasts regarding segmentation #2715

Merged
merged 3 commits into from
Jun 12, 2018
Merged

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Jun 8, 2018

Mailable description of changes:

  • Segmentation-related warnings will be shown less frequent (e.g, not for skeleton tracings when there are multiple resolutions for segmentations anyway).

URL of deployed dev instance (used for testing):

  • http://improvesegtoasts.webknossos.xyz

Steps to test:

  • ensure no warnings are shown for datasets without segmentation
  • for a dataset with only one segmentation-resolution:
    • no warning should be shown for resolution 0
    • ensure that a warning is shown regarding downsampled buckets, when being zoomed out a bit
    • ensure that a warning about unsupported volume is shown as soon as no segmentation is displayed anymore (zoom out further for that)
  • for a dataset with multiple segmentation-resolutions:
    • no warning should be shown for resolution 0
    • ensure that a warning about unsupported volume data when being zoomed out a bit in volume mode (for view + skeleton, there shouldn't be a warning)

Issues:


  • Ready for review

@philippotto philippotto self-assigned this Jun 8, 2018
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm! 🎉

@philippotto philippotto changed the title Show warning-toasts regarding segmentation Improve warning-toasts regarding segmentation Jun 12, 2018
@philippotto philippotto merged commit b1b68a1 into master Jun 12, 2018
@fm3 fm3 deleted the improve-seg-toasts branch June 13, 2018 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve toast warnings regarding segmentation + zoomlevel
2 participants