Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow selecting mapping for thumbnail #6305

Closed
fm3 opened this issue Jun 27, 2022 · 4 comments · Fixed by #8157
Closed

Allow selecting mapping for thumbnail #6305

fm3 opened this issue Jun 27, 2022 · 4 comments · Fixed by #8157

Comments

@fm3
Copy link
Member

fm3 commented Jun 27, 2022

The thumbnail.jpg route of the datastore should support selecting mappings, and the wk-side routes should also use that (let’s discuss how the user should specify what should be used there)

@fm3 fm3 changed the title Allow selectimg mapping for thumbnail Allow selecting mapping for thumbnail Jun 27, 2022
@fm3
Copy link
Member Author

fm3 commented Jun 27, 2022

may be superseded by #3937

@fm3
Copy link
Member Author

fm3 commented Jul 27, 2023

Note that as of #7190 the thumbnail route takes a mappingName parameter. The front-end does not yet make use of that, though. Not sure how the frontend would know which to choose.

@fm3
Copy link
Member Author

fm3 commented Dec 12, 2023

mapping name should probably become a part of the view configuration #7412 then we could take it from there.

@fm3
Copy link
Member Author

fm3 commented Oct 23, 2024

The mappingName is now part of the viewConfiguration, as of #7858
It should be passed to the thumbnail route called in ThumbnailService

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants