Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show case annotations in publications view #3937

Closed
philippotto opened this issue Mar 22, 2019 · 5 comments · Fixed by #6315
Closed

Show case annotations in publications view #3937

philippotto opened this issue Mar 22, 2019 · 5 comments · Fixed by #6315

Comments

@philippotto
Copy link
Member

Right now, featured publications link datasets (including segmentations in case of volume annotations). However, skeleton tracings cannot be linked currently. It would be cool to be able to also link concrete annotations instead of only datasets.

@normanrz
Copy link
Member

We are now routinely having annotations as part of a publication. It would be great if there was a way to attach them to a publication entity.

@fm3 fm3 added the backend label Jan 26, 2021
@fm3
Copy link
Member

fm3 commented Mar 4, 2021

I guess the simplest way for this would be a n:1 relationship (meaning a publication can have n annotations, but an annotation belongs to at most one publication). Do you think that is sufficient?

I would also suggest introducing new routes GET api/publications and GET api/publications/:id, as opposed to the current approach of using the dataset list to scrape this together.

@normanrz
Copy link
Member

normanrz commented Mar 4, 2021

sounds good

@fm3
Copy link
Member

fm3 commented Jun 30, 2022

  • new api route api/publications with new json schema
  • annotation table (schema.sql) should have column _publication, be fetched for above route
  • evolution + version bump for sql schema
  • thumbnail route in tracingstore
    • use mapping, edit position, zoom level from tracing object
    • fetch fallback layer data if needed
  • coordinate with front-end how the api is used
    • (should there be a thumbnail redirect on wk side /annotations/:typ/:id/layer/:tracingId/thumbnail or can the front-end directly query from tracingstore?)
    • what should be in the json? What should be omitted (to avoid data leaks)

@leowe
Copy link
Contributor

leowe commented Jul 13, 2022

While working on the thumbnail route for the annotations, @fm3 and I noticed that it requires a lot more effort than previously thought (which position to show in the thumbnail, how to get all layers from the data set as well, apply mappings, how to fetch the data so that in the buckets where there is no annotation the segmentation is loaded), so we decided to split this task into multiple parts.

Follow-up: #6332

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants