Skip to content

Commit

Permalink
Update Typescript to v4.8 (#6567)
Browse files Browse the repository at this point in the history
* upgrade TS to v4.8

* update prettier to v2.7

* update some eslint plugins

* upgraded changelog
  • Loading branch information
hotzenklotz authored Oct 19, 2022
1 parent f7f5d4a commit f48e589
Show file tree
Hide file tree
Showing 5 changed files with 290 additions and 546 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.unreleased.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ For upgrade instructions, please check the [migration guide](MIGRATIONS.released
### Changed
- Creating tasks in bulk now also supports referencing task types by their summary instead of id. [#6486](https://github.com/scalableminds/webknossos/pull/6486)
- Navbar changes: Move dropdown menu into separate Menu button. Removed toggle-button (cog icon)for left-hand side bar from navbar. [#6558](https://github.com/scalableminds/webknossos/pull/6558)
- Upgraded Typescript to v4.8 [#6567](https://github.com/scalableminds/webknossos/pull/6567)

### Fixed
- Fixed a bug where some file requests replied with error 400 instead of 404, confusing some zarr clients. [#6515](https://github.com/scalableminds/webknossos/pull/6515)
Expand Down
1 change: 0 additions & 1 deletion frontend/javascripts/oxalis/api/api_latest.ts
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,6 @@ class TracingApi {
assertExists(tree, `Couldn't find node ${nodeId}.`);
}

// @ts-expect-error ts-migrate(2532) FIXME: Object is possibly 'undefined'.
const comment = tree.comments.find((__) => __.nodeId === nodeId);
return comment != null ? comment.content : null;
}
Expand Down
1 change: 0 additions & 1 deletion frontend/javascripts/oxalis/api/api_v2.ts
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,6 @@ class TracingApi {
assertExists(tree, `Couldn't find node ${nodeId}.`);
}

// @ts-expect-error ts-migrate(2532) FIXME: Object is possibly 'undefined'.
const comment = tree.comments.find((__) => __.nodeId === nodeId);
return comment != null ? comment.content : null;
}
Expand Down
17 changes: 8 additions & 9 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@
"@types/react-virtualized": "^9.21.21",
"@types/sinon": "^10.0.11",
"@types/url-join": "^4.0.0",
"@typescript-eslint/eslint-plugin": "^5.28.0",
"@typescript-eslint/parser": "^5.28.0",
"@typescript-eslint/eslint-plugin": "^5.40.1",
"@typescript-eslint/parser": "^5.40.1",
"abort-controller": "^3.0.0",
"ava": "^3.13.0",
"babel-eslint": "^9.0.0",
Expand All @@ -58,9 +58,9 @@
"eslint-plugin-eslint-comments": "^3.2.0",
"eslint-plugin-import": "^2.26.0",
"eslint-plugin-jsx-a11y": "^6.5.1",
"eslint-plugin-react": "^7.29.4",
"eslint-plugin-react-hooks": "^4.4.0",
"eslint_d": "^12.0.0",
"eslint-plugin-react": "^7.31.1",
"eslint-plugin-react-hooks": "^4.6.0",
"eslint_d": "^12.2.1",
"espree": "^3.5.4",
"glob": "^7.1.3",
"husky": "^0.14.3",
Expand All @@ -77,7 +77,7 @@
"pg": "^7.4.1",
"pixelmatch": "^5.2.0",
"pngjs": "^3.3.3",
"prettier": "2.6.1",
"prettier": "2.7.1",
"proto-loader6": "^0.4.0",
"puppeteer": "^13.3.2",
"randomstring": "^1.1.5",
Expand All @@ -89,9 +89,8 @@
"shelljs": "^0.8.5",
"sinon": "^12.0.1",
"tmp": "0.0.33",
"ts-loader": "^9.2.8",
"ts-migrate": "^0.1.28",
"typescript": "^4.7.3",
"ts-loader": "^9.4.1",
"typescript": "^4.8.4",
"typescript-coverage-report": "^0.6.4",
"webpack": "^5.66.0",
"webpack-cli": "^4.9.1",
Expand Down
Loading

0 comments on commit f48e589

Please sign in to comment.