Constant folding improvements #3466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottybot
reviewed
Nov 13, 2017
Member
dottybot
left a comment
dottybot
left a comment
There was a problem hiding this comment.
Hello, and thank you for opening this PR! 🎉
All contributors have signed the CLA, thank you! ❤️
Have an awesome day! ☀️
Contributor
|
if(!e) { a } else { b } is now transformed into if(e) { b } else { a }
This case was intentionally not included.
On benchmarking that I did for original optimization this stopped branches
from being merged by further optimizations
…On 13 November 2017 08:05:19 gan_ ***@***.***> wrote:
Expressions with constant type are now folded correctly.
ConstantFold doesn't call typer's `ConstFold.apply` on every expression
making it faster.
`if(!e) { a } else { b }` is now transformed into `if(e) { b } else { a }`
You can view, comment on, or merge this pull request online at:
#3466
-- Commit Summary --
* Merge remote-tracking branch 'origin/const-fold' into wip-local-opt
-- File Changes --
M compiler/src/dotty/tools/dotc/transform/localopt/ConstantFold.scala (38)
M compiler/test/dotty/tools/dotc/SimplifyTests.scala (62)
-- Patch Links --
https://github.com/lampepfl/dotty/pull/3466.patch
https://github.com/lampepfl/dotty/pull/3466.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#3466
|
| // cond.select(defn.Boolean_&&).appliedTo(elsep) | ||
| // the other case ins't handled intentionally. See previous case for explanation | ||
|
|
||
| case If(t @ Select(recv, _), thenp, elsep) if t.symbol eq defn.Boolean_! => |
Contributor
There was a problem hiding this comment.
I'm confused, in the PR description you say that if(!e) { a } else { b } now if(e) { b } else { a }, but it seams that you just removed the case doing that... Could you had a test for this example?
Contributor
Author
There was a problem hiding this comment.
Hi, I looked into it: you are right. It's an error on my part, I didn't add the feature, I only added documentation for it.
Sorry or the confusion...
Expressions with constant type are now folded correctly. ConstantFold doesn't call typer's ConstFold.apply on every expression making it faster
gan74
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expressions with constant type are now folded correctly.
ConstantFold doesn't call typer's
ConstFold.applyon every expression making it faster.if(!e) { a } else { b }is now transformed intoif(e) { b } else { a }