Merged
Conversation
- Add comprehensive CaptureCheckingSignatures test covering arrows,
context functions, by-name, path-dependent captures, reach, consume,
fresh, .rd, .only[Classifier], Mutable/Stateful/Separate, capture-set
variables with bounds, and capability members
- Fix fresh/OnlyCapability being stripped from rendered capture sets
(missing cases in isCapturedInContext)
- Fix dependent function types with fresh in result not preserving
named params and pure arrow (e.g. (x: AnyRef^) -> AnyRef^{fresh})
- Render ^ on capture-set type members (type Cap^)
44f8432 to
441b9b4
Compare
natsukagami
reviewed
Feb 16, 2026
Comment on lines
+500
to
+501
| val sig = tpeTree.asSignature(classDef, symbol.owner) | ||
| val sigWithCaret = if isCaptureVar then Plain("^") :: sig else sig |
Contributor
There was a problem hiding this comment.
Just a note: This seems to be the bounds of the members, so this is more like prepending to >: Lower <: Upper to make ^ >: Lower <: Upper
natsukagami
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should catch rendering issues while evolving the capture checker.
Fixes #24783
Based on #25057