Add library3.properties #24332
Add library3.properties #24332
Conversation
|
|
||
| // If available in the same jar as the stdlib classes, overlay Scala 3 | ||
| // runtime properties contained in `library3.properties` (e.g., version.number). | ||
| val lib3Stream = pickJarBasedOn.getResourceAsStream(lib3Filename) |
There was a problem hiding this comment.
Assuming we're searching for properties based on classpath of Option[?] since 3.8 we're probably never going to find /library.properties, so it seems like we might just start to emit it directly without a fallback.
project/Build.scala
Outdated
| s"""version.number=${version.value} | ||
| |maven.version.number=${version.value} | ||
| |""".stripMargin |
There was a problem hiding this comment.
Scala 2.13 library.properties content:
copyright.string=Copyright 2002-2025, LAMP/EPFL and Lightbend, Inc. dba Akka
maven.version.number=2.13.17
osgi.version.number=2.13.17.v20250930-055830-VFINAL-05169c7
shell.banner=%n ________ ___ / / ___%n / __/ __// _ | / / / _ |%n __\\ \\/ /__/ __ |/ /__/ __ |%n /____/\\___/_/ |_/____/_/ | |%n |/ %s
version.number=2.13.17
We might consider emitting these as well (maybe with exception of osgi.version.number) and updated copyright
Also seems like a good case to refactor to common task/function due to duplicates of code
| lazy val generateLibrary3Properties: Def.Initialize[Task[Seq[File]]] = generatePropertiesFile( | ||
| contents = s"""version.number=${version.value} | ||
| |maven.version.number=${version.value} | ||
| |copyright.string=Copyright 2002-$currentYear, LAMP/EPFL and Lightbend, Inc. dba Akka |
There was a problem hiding this comment.
It should not be only LAMP/EPFL according to compiler.properties from scala3-compiler jar
project/Build.scala
Outdated
| contents = s"""version.number=${version.value} | ||
| |maven.version.number=${version.value} | ||
| |copyright.string=Copyright 2002-$currentYear, LAMP/EPFL and Lightbend, Inc. dba Akka | ||
| |shell.banner=%n ________ ___ / / ___%n / __/ __// _ | / / / _ |%n __\\ \\/ /__/ __ |/ /__/ __ |%n /____/\\___/_/ |_/____/_/ | |%n |/ %s |
There was a problem hiding this comment.
potentatially we could move it variable and interpolate so that it's readable for us
|
It's been a while since I used the old shell banner, but when I did, it inspired me with community spirit! |
| @@ -0,0 +1,7 @@ | |||
| object Test { | |||
| def main(args: Array[String]): Unit = { | |||
| val v = scala.util.Properties.versionNumberString | |||
There was a problem hiding this comment.
Can we also add 1 more test when using scala3-compiler artifact, whcih contains support for detecting Scala version of compiler? It would be useful for me, as I need to detect version of compiler in compiler plugin, see https://github.com/scala-native/scala-native/blob/6ddaf5554a0ea5fdcacfced34bea36856f4c58f2/nscplugin/src/main/scala-3/scala/scalanative/nscplugin/AdaptLazyVals.scala#L27-L31
zielinsky
force-pushed
the
i22144
branch
2 times, most recently
from
0322a9b to
4a17857
Compare
3 participants
Fixes #22144