Skip to content

Ignore warnings when compiletime.testing is imported #24036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 21, 2025
Merged

Ignore warnings when compiletime.testing is imported #24036

merged 3 commits into from
Oct 21, 2025
+43 −2

Conversation

@som-snytt
Copy link
Contributor

@som-snytt som-snytt commented Sep 23, 2025 •
edited
Loading

Fixes #23967

It needs more mechanism for compiletime ops that are inlined but not Inlined.

@som-snytt som-snytt force-pushed the issue/21805-compile-time branch from 2ac247e to b0cd466 Compare October 15, 2025 15:21
@som-snytt som-snytt marked this pull request as ready for review October 15, 2025 15:22
@som-snytt
Copy link
Contributor Author

som-snytt commented Oct 15, 2025 •
edited
Loading

Another idea is that using the compile time facility makes all enclosing imports "used"; that results in false negatives instead of false positives.

Edit: in fact, all the warnings are nullified by the facility. We can't detect the erased usage of typeChecks, so just witnessing the import turns off linting the compilation unit.

The ultimate goal is to represent the typeChecks code as Inlined (by some convention).

@som-snytt som-snytt changed the title Ignore compiletime.testing for warning Ignore warnings when compiletime.testing is imported Oct 15, 2025
@Gedochao Gedochao requested a review from tgodzik October 17, 2025 07:37
tgodzik
tgodzik approved these changes Oct 17, 2025
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@som-snytt som-snytt force-pushed the issue/21805-compile-time branch from 61f29c5 to 7b3a7ad Compare October 21, 2025 14:52
@som-snytt som-snytt merged commit b325681 into scala:main Oct 21, 2025
51 checks passed
@som-snytt som-snytt deleted the issue/21805-compile-time branch October 21, 2025 16:54
@som-snytt
Copy link
Contributor Author

som-snytt commented Oct 21, 2025 •
edited
Loading

Rebased for build fix.

Edit: probably could have just rerun the job?

@WojciechMazur WojciechMazur added the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Oct 22, 2025
@WojciechMazur WojciechMazur mentioned this pull request Oct 22, 2025
Merged
WojciechMazur added a commit that referenced this pull request Oct 22, 2025
@WojciechMazur
Backport "Ignore warnings when compiletime.testing is imported" to 3.…
041ad13 
…7.4 (#24229)

Backports #24036 to the 3.7.4.

PR submitted by the release tooling.
@WojciechMazur WojciechMazur added this to the 3.7.4 milestone Oct 22, 2025
@WojciechMazur WojciechMazur added backport:done This PR was successfully backported. and removed backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. labels Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tgodzik tgodzik tgodzik approved these changes

Assignees

@tgodzik tgodzik

Labels

backport:done This PR was successfully backported.

Projects

None yet

Milestone

3.7.4

Development

Successfully merging this pull request may close these issues.

Wunused: False positive for compiletime.testing.typeCheckErrors

3 participants

@som-snytt @tgodzik @WojciechMazur