Add context parameters to SemanticDB synthetics #23381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for working on this! We simplified a bit the trees in order not to add a new node. Do you need help adjusting the PR according to scalameta/scalameta#4275 ? |
Contributor
Author
|
No problem! I will manage to update it, currently a bit busy on something else atm! |
natsukagami
force-pushed
the
apply-context-semanticsdb
branch
from
062adab to
b1f223a
Compare
tgodzik
pushed a commit
to scala/scala3-lts
that referenced
this pull request
Sep 12, 2025
## Fix scala#22936 Depends on scalameta/scalameta#4272 (for the generated SemanticsDB to be consumable). - Add `ApplyContextTree` from generated code, generated at https://github.com/natsukagami/semanticdb-for-scala3/tree/apply-context-tree - Use ApplyContextTree instead of ApplyTree for context parameter applications [Cherry-picked 4493b49]
WojciechMazur
pushed a commit
that referenced
this pull request
Sep 22, 2025
## Fix #22936 Depends on scalameta/scalameta#4272 (for the generated SemanticsDB to be consumable). - Add `ApplyContextTree` from generated code, generated at https://github.com/natsukagami/semanticdb-for-scala3/tree/apply-context-tree - Use ApplyContextTree instead of ApplyTree for context parameter applications [Cherry-picked 4493b49]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #22936
Depends on scalameta/scalameta#4272 (for the generated SemanticsDB to be consumable).
ApplyContextTreefrom generated code, generated at https://github.com/natsukagami/semanticdb-for-scala3/tree/apply-context-tree