Always transform Inlined.call in CheckUnused #23280
Closed
+11
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still needs a test. |
Do you need help minimizing it ? I can try to take a look |
|
I'll take another swing at the test. Some combination of I confirmed the second example on the ticket is similar; their workaround was to make the given not inline. |
|
Superseded by #24043 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23201
Previously, CheckUnused transformed the
calltree of anInlinednode only after typer (and not after inlining), but inlining also results in non-trivialcalltrees.Needs a minimized test, where an import is required for expansion but is unused at typer.