Skip to content

Backport "Fail compilation if multiple conflicting top-level private defs/vals are in the same package" to 3.7 #22932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2025
Merged

Backport "Fail compilation if multiple conflicting top-level private defs/vals are in the same package" to 3.7 #22932

merged 1 commit into from
Apr 8, 2025
+21 −7

Conversation

@WojciechMazur
Copy link
Contributor

Backports #22759 to the 3.7.0-RC2.

PR submitted by the release tooling.

@jchyb @WojciechMazur
Fail compilation if multiple conflicting top-level private defs/vals …
958e896 
…are in the same package (#22759)

Now the private top level definitions act basically the same as package
private (which is the same behavior as private objects/classes),
as that is what the reference implies, and it helps us avoid ambiguous
method/value selections.
[Cherry-picked 8fe16fe]
Base automatically changed from backport-release-3.7.0-22814 to release-3.7.0 April 8, 2025 09:09
@WojciechMazur WojciechMazur merged commit 6089e02 into release-3.7.0 Apr 8, 2025
52 checks passed
@WojciechMazur WojciechMazur deleted the backport-release-3.7.0-22759 branch April 8, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@WojciechMazur @jchyb