Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MiMa and Reference Version to 3.5.0 #21374

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Update MiMa and Reference Version to 3.5.0 #21374

merged 2 commits into from
Aug 13, 2024

Conversation

hamzaremmal
Copy link
Member

No description provided.

@hamzaremmal hamzaremmal added the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Aug 12, 2024
@hamzaremmal hamzaremmal merged commit 16be717 into scala:main Aug 13, 2024
28 checks passed
@hamzaremmal hamzaremmal deleted the mima-filters branch August 13, 2024 08:56
@WojciechMazur WojciechMazur added backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" and removed backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. labels Aug 13, 2024
@WojciechMazur WojciechMazur mentioned this pull request Aug 13, 2024
Merged
@WojciechMazur
Copy link
Contributor

I'm wondering how this PR passed the MiMa checks when compared with the last LTS.
In the 3.5.1 backport PR and when checking out the current main (after the merge) it fails without adding these expected changes 05ef893 🤔

WojciechMazur added a commit that referenced this pull request Aug 13, 2024
@WojciechMazur
Backport "Update MiMa and Reference Version to 3.5.0" to 3.5.1 (#21376)
34b2875 
Backports #21374 to 3.5.1-RC2
@WojciechMazur WojciechMazur added backport:done This PR was successfully backported. and removed backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" labels Aug 13, 2024
@hamzaremmal hamzaremmal mentioned this pull request Aug 13, 2024
Merged
@hamzaremmal
Copy link
Member Author

hamzaremmal commented Aug 13, 2024 •
edited
Loading

So, this PR passed the MiMa check because the current baseVersion is set to 3.6.0. Following the current configuration

scala3/project/Build.scala

Line 139 in 1913367

case VersionRE(_, "0") => CompatMode.BinaryCompatible
we will only check for backwards binary compatibility (and filtering is not required). In the backport PR, the baseVersion was set to 3.5.1, which means we will also check for forward compatibility (therefore, the filtering is required). I've opened a PR to add the missing filters to avoid the same issue when we move to 3.6.1. (The PR also fixes a typo in the version regex).

Also, in 3.5.1, we were comparing against 3.5.0-RC1 before #21376 and we didn't introduce the breaking changes until 3.5.0-RC7 if I recall correctly.

hamzaremmal added a commit that referenced this pull request Aug 13, 2024
@hamzaremmal
Fix and Update MiMa filters (#21379)
f1adc55 
Fix #21374 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WojciechMazur WojciechMazur WojciechMazur approved these changes

@Kordyjan Kordyjan Awaiting requested review from Kordyjan

Assignees

@Kordyjan Kordyjan

@WojciechMazur WojciechMazur

Labels
backport:done This PR was successfully backported.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hamzaremmal @WojciechMazur @Kordyjan