Require named arguments for java defined annotations #21329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjrd
reviewed
Aug 5, 2024
Gedochao
added
the
needs-minor-release
sjrd
requested changes
Aug 6, 2024
sjrd
approved these changes
Aug 6, 2024
hamzaremmal
commented
Aug 6, 2024
| annot match | ||
| case untpd.Apply(fun, params) if hasOnePositionalParameter(params) && annotationHasValueField => | ||
| untpd.cpy.Apply(annot)(fun, params.mapConserve(mapPositionalToNamed)) | ||
| case untpd.Apply(_, params) => |
There was a problem hiding this comment.
@sjrd I removed the following condition here: hasOnePositionalParameter(params)
sjrd
requested changes
Aug 6, 2024
sjrd
approved these changes
Aug 6, 2024
hamzaremmal
added a commit
that referenced
this pull request
Aug 20, 2024
…1397) Followup to #21329 It might be beneficial for Scala 3.6 migration to allow for an automatic rewrite of unnamed Java annotation parameters to ease the migration. We can assume that already compiling code is already using correct positions for annotation arguments. Based on that, we can use the order of the annotation decls and their indexes to assume the names of annotation arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20554