add child to parent in completion context #21214
Merged
+1,361
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bishabosha
commented
Jul 17, 2024
| 1884: 293 .. 293 | ||
|
|
||
| source paths: | ||
| 0: 27 [<elided source file name>] |
There was a problem hiding this comment.
the magic is that if you revert the change to Namer, then this will have three source paths - because the positions of the child annotations will be set in the context of A.scala - i.e. the call site that forces the completion
This ensures that the positions of forced Child annotations always happens in the source file of the parent class, and not in another file that forced the completion to happen
bishabosha
force-pushed
the
fix-child-creation-ctx
branch
from
06bd788
to
a2bec5e
Compare
raboof
approved these changes
Jul 18, 2024
There was a problem hiding this comment.
I tested this PR with my reproducer at https://codeberg.org/raboof/scala3-reproduce-21154 (invoking scalac directly, no sbt), and it appears to have the intended effect: no more references to FcmJsonSupport.scala in FcmOption.tasty, and also the previously-nondeterministic 'positions' entries are gone.
sjrd
approved these changes
Jul 24, 2024
This was referenced Jul 24, 2024
hamzaremmal
added a commit
that referenced
this pull request
Jul 25, 2024
unfortunately it seems changing the classpath means representation of TASTy is not stable (but is semantically equivalent) i.e. some SHAREDtype might be replaced by equivalent types. This breaks the tastycheck test in #21214 with scala 2 library tasty. By changing to ordinary classes instead of enum cases, we limit generated code and avoid these specific examples of instability in the test. Manually, I confirmed that reverting the change to namer in #21214 still breaks the new test [test_scala2_library_tasty]
WojciechMazur
added a commit
that referenced
this pull request
Aug 27, 2024
Backports #21214 to the 3.5.2 branch. PR submitted by the release tooling. [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that the positions of forced Child annotations always happens in the source file of the parent class, and not in another file that forced the completion to happen
fixes #21154