feat: Implement completions for named tuple fields #21202
Merged
+96
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rochala
reviewed
Jul 17, 2024
There was a problem hiding this comment.
Also, could you add one more test case in scala3-language-server/CompletionTest.scala ? Right now this is the place where we test only the compiler completions. In the future, it should be migrated to presentation compiler, but as of now this is a technical debt
Co-authored-by: Jędrzej Rochala <[email protected]>
…t to CompletionTest
rochala
approved these changes
Jul 17, 2024
WojciechMazur
pushed a commit
that referenced
this pull request
Aug 28, 2024
closes #20478 --------- Co-authored-by: Jędrzej Rochala <[email protected]> [Cherry-picked 3e78238]
This was referenced Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #20478