Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport "Fix deterministically adding additional interfaces" to LTS #21151

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

WojciechMazur
Copy link
Contributor

Backports #20593 to the LTS branch.

PR submitted by the release tooling.
[skip ci]

When a class contains calls to 'super' for traits it does
not directly implement, these are added to the list of interfaces
of the generated class. Previously, because these interfaces were
determined using set logic, the ordering of that list was not
deterministic.

This change makes the order deterministic (assuming the order in
which these calls are registered using `registerSuperCall` in the
`CollectSuperCalls` phase is deterministic within each class)

Fixes #20496

[Cherry-picked 7500b05][modified]
Base automatically changed from lts-20815 to lts-3.3 July 10, 2024 14:24
@WojciechMazur
Copy link
Contributor Author

No regressions detected in the community build up to lts-20902.

Reference

@WojciechMazur WojciechMazur merged commit 5310094 into lts-3.3 Jul 10, 2024
19 checks passed
@WojciechMazur WojciechMazur deleted the lts-20593 branch July 10, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant