Refine ignored cases for unused params check #20973
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aherlihy
reviewed
Jul 3, 2024
| @@ -0,0 +1,20 @@ | |||
| //> using options -Wunused:params | |||
There was a problem hiding this comment.
If it's the case that this subsumes the ticket for warning in a for comprehension (e.g. the case for x <- list yield y // warn for x, #18289) then we should add a test for that syntax as well since that ticket will no longer require any changes.
There was a problem hiding this comment.
I also would not consider it a problem that the for comprehension warning is unused parameter instead of local. The only way around that would run into the same issues as #18854 and may be subject to the for-comprehension desugaring changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20951
However I don't think the current implementation is perfect:
unused:paramsdoes not trigger a warning when the return value of a method is a constant but thenunused:alldoes trigger a warning:unused local definition. But maybe that should be solved in a different PR.This will also trigger compiler warnings for the examples in #18289 but the warning is
unused explicit parameterinstead ofunused local definition.