Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport "Priority warning fix alternative" to 3.5.0 #20953

Merged
merged 5 commits into from
Jul 3, 2024
Merged

Backport "Priority warning fix alternative" to 3.5.0 #20953

merged 5 commits into from
Jul 3, 2024

Commits on Jul 2, 2024

  1. Avoid useless warnings about priority change in implicit search 

    Warn about priority change in implicit search only if one of the participating
candidates appears in the final result.

It could be that we have an priority change between two ranked candidates that
both are superseded by the result of the implicit search. In this case, no
warning needs to be reported.
    @odersky @WojciechMazur
    odersky authored and WojciechMazur committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    91b8abd View commit details
    Browse the repository at this point in the history

  2. Re-enable semanticdb test

    @odersky @WojciechMazur
    odersky authored and WojciechMazur committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    9354ad5 View commit details
    Browse the repository at this point in the history

  3. Update semanticDB expect files

    @odersky @WojciechMazur
    odersky authored and WojciechMazur committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    7ac5417 View commit details
    Browse the repository at this point in the history

  4. Drop priority change warnings that don't qualify 

    Drop priority change warnings if one the mentioned references
does not succeed via tryImplicit.
    @odersky @WojciechMazur
    odersky authored and WojciechMazur committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    0b812bd View commit details
    Browse the repository at this point in the history

  5. Add test for scala#20484

    @odersky @WojciechMazur
    odersky authored and WojciechMazur committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    1d993a7 View commit details
    Browse the repository at this point in the history