Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #18238: Emit an explicit LineNumber for empty else branches. #20814

Closed
wants to merge 1 commit into from
Closed

Fix #18238: Emit an explicit LineNumber for empty else branches. #20814

wants to merge 1 commit into from

Conversation

sjrd
Copy link
Member

@sjrd sjrd commented Jun 26, 2024

If we don't, the code generated for the else branch remains associated with the last instruction of the then branch, which yields to confusing debugging sessions.

@sjrd
Fix scala#18238: Emit an explicit LineNumber for empty else branches.
04368da 
If we don't, the code generated for the `else` branch remains
associated with the last instruction of the `then` branch, which
yields to confusing debugging sessions.
@sjrd sjrd requested a review from WojciechMazur June 26, 2024 09:27
@sjrd
Copy link
Member Author

sjrd commented Jun 26, 2024

Ah, this had already been done, with better handling of the corner cases, in #20431. Well at least the fact that I fixed it in essentially the same way means it's probably correct, so I merged #20431.

@sjrd sjrd closed this Jun 26, 2024
@sjrd sjrd deleted the fix-i18238 branch June 26, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WojciechMazur WojciechMazur Awaiting requested review from WojciechMazur

Assignees

@WojciechMazur WojciechMazur

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjrd @WojciechMazur