Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Exclude newer LSP4j, which is built on JDK 11 #20771

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Jun 24, 2024

It seems the CI started failing because of out bump, but that was not picked up aside from windows tests weirdly.

Metals recently updated to newest LSP4j, though I think nothing new was added and no changes were done to the presentation compiler so we should be ok to downgrade locally: https://github.com/scalameta/metals/pull/6126/files

The update was mostly done so that we done fall behind in the LSP standard, but this might become a problem in the future here. Do we ever plan do drop supporting JDK 8?

It seems the CI started failing because of out bump, but that was not picked up aside from windows tests weirdly.

Metals recently updated to newest LSP4j, though I think nothing new was added and no changes were done to the presentation compiler so we should be ok to downgrade locally: https://github.com/scalameta/metals/pull/6126/files

The update was mostly done so that we done fall behind in the LSP standard, but this might become a problem in the future here. Do we ever plan do drop supporting JDK 8?
@tgodzik tgodzik requested a review from rochala June 24, 2024 17:55
@rochala
Copy link
Contributor

rochala commented Jun 24, 2024

Maybe we should consider enabling windows CI for all presentation compiler PRs to avoid situations like this ? This is the module that is most likely to be affected by different OS, and presentation compiler tests are super quick ~~ 30 sec for the test suite. @hamzaremmal

As of dropping support for JDK 8 I don't think this is happening any time soon.
But I suppose, we may be able to release presentation compiler for JDK 11+ ?

@tgodzik
Copy link
Contributor Author

tgodzik commented Jun 24, 2024

But I suppose, we may be able to release presentation compiler for JDK 11+ ?

I would opt for that if possible.

@Gedochao Gedochao linked an issue Jun 25, 2024 that may be closed by this pull request
@Gedochao
Copy link
Contributor

But I suppose, we may be able to release presentation compiler for JDK 11+ ?

I'll raise the topic on this week's core meeting.

@Gedochao
Copy link
Contributor

Maybe we should consider enabling windows CI for all presentation compiler PRs to avoid situations like this ? This is the module that is most likely to be affected by different OS, and presentation compiler tests are super quick ~~ 30 sec for the test suite.

+1

@tgodzik tgodzik marked this pull request as ready for review June 25, 2024 08:16
@tgodzik tgodzik merged commit 4ff676e into scala:main Jun 25, 2024
24 checks passed
@tgodzik tgodzik deleted the fix-ci branch June 25, 2024 08:20
@Kordyjan Kordyjan added this to the 3.5.1 milestone Jul 3, 2024
WojciechMazur added a commit that referenced this pull request Jul 10, 2024
…TS (#21145)

Backports #20771 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nightly Dotty workflow of 2024-06-25 failed
4 participants