-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Chocolatey #20534
Draft
hamzaremmal
wants to merge
9
commits into
scala:main
Choose a base branch
from
hamzaremmal:chocolatey-config
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add support for Chocolatey #20534
+409
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamzaremmal
force-pushed
the
chocolatey-config
branch
2 times, most recently
from
June 8, 2024 20:17
133391d
to
0934b95
Compare
hamzaremmal
commented
Jun 13, 2024
<projectUrl>https://scala-lang.org/</projectUrl> | ||
<bugTrackerUrl>https://github.com/scala/scala3/issues</bugTrackerUrl> | ||
<copyright>© 2002-2024, LAMP/EPFL</copyright> | ||
<iconUrl>https://cdn.jsdelivr.net/gh/scala/scala3@version/pkgs/chocolatey/icon.svg</iconUrl> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will have to add the commit hash after we merge it here
Suggested change
<iconUrl>https://cdn.jsdelivr.net/gh/scala/scala3@version/pkgs/chocolatey/icon.svg</iconUrl> | |
<iconUrl>https://cdn.jsdelivr.net/gh/scala/scala3@<merge-commit>/pkgs/chocolatey/icon.svg</iconUrl> |
hamzaremmal
force-pushed
the
chocolatey-config
branch
from
June 21, 2024 15:20
1f23b0b
to
45d5f88
Compare
hamzaremmal
force-pushed
the
chocolatey-config
branch
5 times, most recently
from
July 16, 2024 09:38
4323309
to
4c8f0f7
Compare
hamzaremmal
force-pushed
the
chocolatey-config
branch
3 times, most recently
from
July 16, 2024 13:49
d13aa64
to
ef93210
Compare
hamzaremmal
force-pushed
the
chocolatey-config
branch
from
July 16, 2024 14:08
ef93210
to
26bdbee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20380
TODO:
[x] Generatemsi
files forscala
(issue: Publish platform-native launchers for Scala CLI as thescala
runner command #20378) (Will be done in another PR, but we should already know the format of the URL)publish-chocolatey.yml
)logo.ico
) file[test_chocolatey]
[skip ci]