completions: do not complete package #20532
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an issue with completions for package in Metals. ```scala // code package one@@ // compeltions oneCURSOR ``` It seems there is no need in completions for Package at all.
|
@rochala btw, do you know if it should be backported to metals or not? |
|
Hey, so the situation is as follows. Short answer: there is no need Long answer: Metals is no longer publishing mtags for >= 3.4.0. We will also stop releasing them for LTS line in the near future (as soon as we backport most of the latest changes to the LTS branch). Hopefully it will be 3.3.4 |
rochala
requested changes
Jun 7, 2024
| @@ -211,6 +211,8 @@ object Completion: | |||
| val completer = new Completer(mode, pos, untpdPath, matches0) | |||
|
|
|||
| val result = adjustedPath match | |||
| // Ignore `package foo@@` and `package foo.bar@@` | |||
| case ((_: tpd.Select) | (_: tpd.Ident)):: (_ : tpd.PackageDef) :: _ => Map.empty | |||
There was a problem hiding this comment.
The check is correct, but it may be better to make it in Completion.completionMode instead of this place. The reason is that despite filtering compiler completions, completion mode is also used for the rest of the completions in presentation compiler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue with completions for package in Metals.
It seems there is no need in completions for Package at all.