Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discard poly-functions when trying to resolve overloading #20181

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Discard poly-functions when trying to resolve overloading #20181

merged 1 commit into from
Apr 17, 2024

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Apr 14, 2024 •
edited
Loading

Discard poly-functions when trying to resolve overloading using subsequent parameter lists. Polyfunctions don't have a symbol, so the logic of remapping arguments does not work for them.

Fixes #20176

@odersky
Discard poly-functions when trying to resolve overloading
4cea282 
Discard poly-functions when trying to resolve overloading using subsequent parameter lists. Polyfunctions don't have a symbol, so the logic of remapping arguments does not work for them.
@odersky odersky requested a review from Sporarum April 15, 2024 10:53
Sporarum
Sporarum approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@Sporarum Sporarum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me !

@odersky odersky merged commit 093a50d into scala:main Apr 17, 2024
19 checks passed
@odersky odersky deleted the fix-20176 branch April 17, 2024 15:34
@Kordyjan Kordyjan added this to the 3.5.0 milestone May 10, 2024
@WojciechMazur WojciechMazur mentioned this pull request Jul 6, 2024
Merged
WojciechMazur added a commit that referenced this pull request Jul 6, 2024
@WojciechMazur
Backport "Discard poly-functions when trying to resolve overloading" …
ab8df25 
…to LTS (#21076)

Backports #20181 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sporarum Sporarum Sporarum approved these changes

Assignees

@Sporarum Sporarum

Labels
None yet
Projects
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.

Compiler crash after adding an using clause to an otherwise ambigous def that returns a polymorphic function
3 participants
@odersky @Sporarum @Kordyjan