Backport fix #19536 of Scala.js Dynamic #19979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… classes. One boolean value was the wrong way around for native JS classes and traits. That caused `scala.Dynamic` not to be removed from the super-interfaces of native JS classes at the IR level, causing the linking error. (cherry picked from commit 59ebb85)
sjrd
approved these changes
Mar 19, 2024
Gedochao
added
backport:nominated
|
Can this backport PR be accepted / merged? The original PR is still listed as Needs Assessment in https://github.com/orgs/lampepfl/projects/6 |
|
All right I'll just take responsibility for merging this one into 3.3.x. It's an obvious, straightforward fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport cherry-pick, as discussed in #19536