[WIP] Handle match types reducing to ErrorType in TypeComparer
#19961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A match type has no matching cases is reduced to an `ErrorType` (different from throwing a TypeError), in distinction to the other cases for failed match type reduction which return `NoType`. Producing to an ErrorType is usually accompanied by reporting an error, but does appear to be the case when attempting normalization from within the TypeComparer.
Prior to the changes contained, subtyping trace contained:
```
<== isSubType <error The match type contains an illegal case:
case AnyInt[a] => scala.compiletime.ops.int.S[a]
(this error can be ignored for now with `-source:3.3`)> <:< Nothing = true
<== isSubType IndexOf[String,
Tuple.Drop[(String, Int, String, Boolean),
scala.compiletime.ops.int.S[IndexOf[String, (String, Int, String, Boolean)]]
]
] <:< Nothing = true
```
This was referenced Mar 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #19953, #19954
Fixes #19949
Fixes #19950