Adjust owner in Interactive.contextOfPath causing crash in ImplicitSearch

[rochala]

Interactive provided us with the method contextOfPath which should return enclosing ctx for given position. It was working fine until given loop detection was improved some time ago.

It started crashing as the context owner was set to original context owner, instead of the real owner. This PR changes this and sets context to its outer context owner.

Fixes scalameta/metals#6193

[smarter]

LGTM! I just now realized that maybe we could use the context returned by contextOfPath to determine which names can be printed without a qualifying path (so like ShortenedTypePrinter, but could be re-used for compiler error messages), does that make any sense?

[smarter]

Also it seems like this should be backported to 3.4.1. (I assume the given loop change isn't in 3.3 ?)

[rochala]

LGTM! I just now realized that maybe we could use the context returned by contextOfPath to determine which names can be printed without a qualifying path (so like ShortenedTypePrinter, but could be re-used for compiler error messages), does that make any sense?

This is actually a good idea. I think current ShortenedTypePrinter does similar stuff using IndexedContext, but it also handles symbols that are about to be added e.g. if we already have Foo in scope, and want to complete other Foo from symbol index, it would prepend prefixes until the conflict is resolved.

If we approach this problem in error messages, we can shorten types to current scope.
This will be great improvement. I'm curious how it will handle errors coming from other source files, e.g.

// fileA.scala
package test.api
class Foo()
def test(x: Foo): Unit = ???

// fileB.scala
package test.newApi
class Foo(x: Int)
test.api.test(Foo(5)) // it should report 
  // type mismatch;
  // found:    newApi.Foo
  // required: api.Foo
  // test.api.test(Foo(5))
  //               ^^^^^^