Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Done: transfer of the repository to scala/scala3 #19839

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

hamzaremmal
Copy link
Member

@hamzaremmal hamzaremmal commented Mar 1, 2024

This PR is part of the upcoming transfer of the lampepfl/dotty repository to the scala organisation (scala/scala3).

@hamzaremmal
Copy link
Member Author

hamzaremmal commented Mar 1, 2024

Protocol for transfering lampepfl/dotty to scala/scala3

By @hamzaremmal and @sjrd


  • Remove all the runners from lampepfl/dotty repository.
    We need to make sure that the runners don't execute any job when they are transferred.
    To check this: https://github.com/organizations/lampepfl/settings/actions/runners

  • Transfer the repository to the scala organization.
    The renaming of the repository should be done at that moment, not later.
    (We believe that this is important for redirections; dry-run was completed this way).

  • Copy and link all the GitHub Projects related to lampepfl/dotty. The projects are the following:

Benchmarking infrastructure:

@mbovel will do the necessary after the transfer.

@hamzaremmal
Copy link
Member Author

Second commit in this PR is not important to have a successful transfer.
Note to myself: Should I move it to a different PR ?

@SethTisue
Copy link
Member

This is really minor, but once it's transferred, it should also become of the "pinned" repos at https://github.com/scala . (I just unpinned something else to make room for it.)

@hamzaremmal
Copy link
Member Author

This is really minor, but once it's transferred, it should also become of the "pinned" repos at https://github.com/scala . (I just unpinned something else to make room for it.)

I had it in mind but I forgot to add it in the protocol. Just did.

@SethTisue
Copy link
Member

SethTisue commented Mar 2, 2024

s/commiters/committers/

@SethTisue
Copy link
Member

SethTisue commented Mar 2, 2024

about teams and permissions, if people feel that the right thing is to have Scala 3 specific GitHub teams, for permissions purposes, then great, I certainly don't object. but if it's being kept separate out of fear that you'll, like, step on Lightbend's toes, or disrupt tradition, or anything like that, you really needn't worry, it's fine, let's do whatever makes sense and isn't overly elaborate. cc @lrytz

@sjrd
Copy link
Member

sjrd commented Mar 4, 2024

Second commit in this PR is not important to have a successful transfer. Note to myself: Should I move it to a different PR ?

I suggest we keep it for a separate PR that we'll do once we have confirmed that we have a working CI after the migration. This way, we will actually get a proper CI run of these additional changes.

@hamzaremmal
Copy link
Member Author

Second commit in this PR is not important to have a successful transfer. Note to myself: Should I move it to a different PR ?

I suggest we keep it for a separate PR that we'll do once we have confirmed that we have a working CI after the migration. This way, we will actually get a proper CI run of these additional changes.

Agreed 👍

@sjrd
Copy link
Member

sjrd commented Mar 4, 2024

about teams and permissions, if people feel that the right thing is to have Scala 3 specific GitHub teams, for permissions purposes, then great, I certainly don't object. but if it's being kept separate out of fear that you'll, like, step on Lightbend's toes, or disrupt tradition, or anything like that, you really needn't worry, it's fine, let's do whatever makes sense and isn't overly elaborate. cc @lrytz

IMO we could do that in a second phase. I'd like to minimize the amount of changes that we have to do at the time of the migration itself.

@hamzaremmal
Copy link
Member Author

Second commit was moved to the following PR:

@hamzaremmal hamzaremmal changed the title Prepare the transfer of the repository to scala/scala3 In progress: transfer of the repository to scala/scala3 Mar 6, 2024
@hamzaremmal hamzaremmal marked this pull request as ready for review March 6, 2024 08:43
@hamzaremmal hamzaremmal added the backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" label Mar 6, 2024
@hamzaremmal
Copy link
Member Author

@Kordyjan This PR needs to be backported ASAP to the LTS branch (to have the new configuration setup).

It should also be backported to any active release branch too (mainly release-3.4.1)

@hamzaremmal hamzaremmal merged commit 7dc4d3d into scala:main Mar 6, 2024
19 checks passed
@hamzaremmal hamzaremmal deleted the scala/scala3 branch March 6, 2024 10:29
@hamzaremmal hamzaremmal changed the title In progress: transfer of the repository to scala/scala3 Done: transfer of the repository to scala/scala3 Mar 6, 2024
@Kordyjan
Copy link
Contributor

Kordyjan commented Mar 6, 2024

@Kordyjan This PR needs to be backported ASAP to the LTS branch (to have the new configuration setup).

Backported to all relevant branches.

@Kordyjan
Copy link
Contributor

Kordyjan commented Mar 6, 2024

Check if the backport to LTS project workflow is still working.

Looks like it follows the redirects correctly, so nothing urgent to do here.

@hamzaremmal
Copy link
Member Author

Check if the backport to LTS project workflow is still working.

Looks like it follows the redirects correctly, so nothing urgent to do here.

@Kordyjan There is a new project in the scala organization (https://github.com/orgs/scala/projects/2). The other one still has all the old PRs and we will be retiring it slowly. New PRs should go to this new project.

bishabosha added a commit that referenced this pull request Mar 6, 2024
@Kordyjan Kordyjan removed the backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" label Mar 12, 2024
@Kordyjan Kordyjan added this to the 3.4.2 milestone Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transfer of the repo to scala/scala3
4 participants