Attempt implicit search for old style implicit parameters in Application matchArgs
#19737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(not only `using` params)
EugeneFlesselle
changed the title
implicit parametersimplicit parameters in Application matchArgs
EugeneFlesselle
changed the title
implicit parameters in Application matchArgsimplicit parameters in Application matchArgs
hamzaremmal
reviewed
Feb 25, 2024
| @@ -638,7 +638,7 @@ trait Applications extends Compatibility { | |||
| defaultArg.tpe.widen match | |||
| case _: MethodOrPoly if testOnly => matchArgs(args1, formals1, n + 1) | |||
| case _ => matchArgs(args1, addTyped(treeToArg(defaultArg)), n + 1) | |||
| else if methodType.isContextualMethod && ctx.mode.is(Mode.ImplicitsEnabled) then | |||
| else if methodType.isImplicitMethod && ctx.mode.is(Mode.ImplicitsEnabled) then | |||
There was a problem hiding this comment.
isImplicitMethod covers both implicit and contextual 👍🏻
final override def isImplicitMethod: Boolean =
companion.eq(ImplicitMethodType) || isContextualMethod
hamzaremmal
approved these changes
Feb 25, 2024
|
Will this be in the 3.3.2 release? Or does it need to be back ported? |
|
No, 3.3.2 is already in Maven Central. |
mzuehlke
added a commit
to mzuehlke/munit
that referenced
this pull request
Apr 26, 2024
As there isn't an artifact for Scala 3 LTS that includes scala/scala3#20171 I gave it a try with 3.4.2-RC1 that already contains scala/scala3#19737 This PR shows that the only thing that changes is the message returned form the compiler and not changes to munit are needed once Scala 3 LTS with the fix gets released.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19594