Add supports for type cast and filtering type for field and method owner in global initialization checker #19612
Conversation
| case ref: Ref if ref.klass.isSubClass(klass) => ref | ||
| case ref: Ref => Bottom | ||
| case ValueSet(values) => values.map(v => v.filterClass(klass)).join | ||
| case _ => a // TODO: could be more precise for OfArray; possibly add class information for Fun |
There was a problem hiding this comment.
As discussed in the meeting, we can further filter OfArray here. Meanwhile, we can remove the old code that partially handles this.
| def unapply(tree: Tree)(using Context): Option[(Tree, Type)] = | ||
| tree match | ||
| case TypeApply(Select(qual, _), typeArg) if tree.symbol.isTypeCast => | ||
| Some(qual, typeArg.head.tpe) |
There was a problem hiding this comment.
Minor: It's better to changetypeArg to typeArgs.
| val baseClasses = tpe.baseClasses | ||
| if baseClasses.isEmpty then a | ||
| else tpe match | ||
| case t @ SAMType(_, _) if a.isInstanceOf[Fun] => a // if tpe is SAMType and a is Fun, allow it |
There was a problem hiding this comment.
This case doesn't seem to use the baseclasses. Should all the baseclasses stuff (and the check for empty baseclasses) be pushed down into the second case? Also, perhaps headOption is useful on the baseclasses.
| @@ -1549,7 +1572,7 @@ object Objects: | |||
| report.warning("The argument should be a constant integer value", arg) | |||
| res.widen(1) | |||
| case _ => | |||
| res.widen(1) | |||
| if res.isInstanceOf[Fun] then res.widen(2) else res.widen(1) // TODO: changing to widen(2) causes standard library analysis to loop infinitely | |||
There was a problem hiding this comment.
Remove the comment because we now know it's not infinite.
| val klass = sym.asClass | ||
| a match | ||
| case Cold => Cold | ||
| case ref: Ref if ref.klass.isSubClass(klass) => ref |
There was a problem hiding this comment.
For consistency with other cases, I'd move the if inside the case body and combine with the following case.
This PR adds support for more precise analysis of type casting in global initialization checker, which filters impossible classes after reference casting and preserves only possible classes. It also automatically filter the set of possible classes during field selection or method invocation and only preserves owners of the field/method