Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Java record problems (#19578) and (#19386) #19583

Merged
merged 6 commits into from
Feb 9, 2024
Merged

Fix Java record problems (#19578) and (#19386) #19583

merged 6 commits into from
Feb 9, 2024

Commits on Jan 31, 2024

  1. Add regression test for generic records (scala#19578)

    @yilinwei
    yilinwei committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    64a8865 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. Fix records with type parameters (scala#19578). 

    This fixes a whole host of subtle issues.

 - The type parameter was not stamped correctly on the constructor
   causing the original error
 - The parsed record was not stamped with `JavaDefined`, which meant
   the duplicate constructors in the case of overrides were not
   removed.
    @yilinwei
    yilinwei committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    f7eb589 View commit details
    Browse the repository at this point in the history

  2. Add arity 0 regression test for records.

    @yilinwei
    yilinwei committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    781c25f View commit details
    Browse the repository at this point in the history

  3. Fixes record accessors incorrect signature (scala#19386). 

    We change the proxy method to take in a single argument. This also
exposed a second issue where the overriden methods were not
invalidated correctly in the `Namer`.
    @yilinwei
    yilinwei committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    47511ae View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2024

  1. Add extra predicate check in canBeInvalidated

    @yilinwei
    yilinwei committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    c532dd7 View commit details
    Browse the repository at this point in the history

  2. Remove redundant definesMember check.

    @yilinwei
    yilinwei committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    5be6fac View commit details
    Browse the repository at this point in the history