-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TypeTreeTypeTest
to not match TypeBoundsTree
s
#19485
Conversation
4b32794
to
4c3ebdf
Compare
The original issue was that in the following pattern match the trait TreeMap:
def transformTree(tree: Tree)(owner: Symbol): Tree =
tree match
...
case tree: TypeTree => ...
case tree: TypeBoundsTree => ...
... |
I tested this and it works with a regular type parameter, but still does not work with a higher-kinded parameter, e.g. val t = '{class K[T[_]]}.asTerm Now failing with the following exception:
|
4c3ebdf
to
5d7cf2b
Compare
works now |
Also see `TypeBoundsTreeTypeTest` in `QuotesImpl` and `Quotes` spec ``` * +- TypeTree ----+- Inferred * | +- ... * | ... * +- TypeBoundsTree ``` Fixes scala#19480
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Sorry for not looking at this sooner, I must have somehow missed this
Also see
TypeBoundsTreeTypeTest
inQuotesImpl
andQuotes
specFixes #19480