Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update staging.md #19374

Closed
wants to merge 1 commit into from
Closed

Update staging.md #19374

wants to merge 1 commit into from

Conversation

Bersier
Copy link
Contributor

@Bersier Bersier commented Jan 4, 2024

@@ -108,7 +108,7 @@ to get a source-like representation of the expression.
import scala.quoted.*

// make available the necessary compiler for runtime code generation
given staging.Compiler = staging.Compiler.make(getClass.getClassLoader)
given staging.Compiler = staging.Compiler.make(Predef.getClass.getClassLoader)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That might not be the correct classloader. The standard library might be loaded earlier with a different classloader. We need to get it from a class defined in the current project.

I am not sure what is the cleanest encantation for this one that we cannot the the classloader of the synthetic package object.

@Bersier Bersier closed this Jan 4, 2024
@Bersier Bersier deleted the patch-6 branch February 9, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants