Make explicit arguments for context bounds an error from 3.5 #19316
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,108 @@ | ||||||
| package dotty.tools | ||||||
| package dotc | ||||||
| package typer | ||||||
|
|
||||||
| import core.* | ||||||
| import ast.* | ||||||
| import Contexts.* | ||||||
| import Types.* | ||||||
| import Flags.* | ||||||
| import Names.* | ||||||
| import StdNames.* | ||||||
| import Symbols.* | ||||||
| import Trees.* | ||||||
| import ProtoTypes.* | ||||||
| import Decorators.* | ||||||
| import config.MigrationVersion | ||||||
| import config.Feature.{sourceVersion, migrateTo3} | ||||||
| import config.SourceVersion.* | ||||||
| import reporting.* | ||||||
| import NameKinds.ContextBoundParamName | ||||||
| import rewrites.Rewrites.patch | ||||||
| import util.Spans.Span | ||||||
| import rewrites.Rewrites | ||||||
|
|
||||||
| /** A utility trait containing source-dependent deprecation messages | ||||||
| * and migrations. | ||||||
| */ | ||||||
| trait Migrations: | ||||||
| this: Typer => | ||||||
|
|
||||||
| import tpd.* | ||||||
|
|
||||||
| /** Flag & migrate `?` used as a higher-kinded type parameter | ||||||
| * Warning in 3.0-migration, error from 3.0 | ||||||
| */ | ||||||
| def kindProjectorQMark(tree: untpd.TypeDef, sym: Symbol)(using Context): Unit = | ||||||
| if tree.name eq tpnme.? then | ||||||
| val addendum = if sym.owner.is(TypeParam) | ||||||
| then ", use `_` to denote a higher-kinded type parameter" | ||||||
| else "" | ||||||
| val namePos = tree.sourcePos.withSpan(tree.nameSpan) | ||||||
| report.errorOrMigrationWarning( | ||||||
| em"`?` is not a valid type name$addendum", namePos, MigrationVersion.Scala2to3) | ||||||
|
|
||||||
| def typedAsFunction(tree: untpd.PostfixOp, pt: Type)(using Context): Tree = { | ||||||
| val untpd.PostfixOp(qual, Ident(nme.WILDCARD)) = tree: @unchecked | ||||||
| val pt1 = if (defn.isFunctionNType(pt)) pt else AnyFunctionProto | ||||||
| val nestedCtx = ctx.fresh.setNewTyperState() | ||||||
| val res = typed(qual, pt1)(using nestedCtx) | ||||||
| res match { | ||||||
| case closure(_, _, _) => | ||||||
| case _ => | ||||||
| val recovered = typed(qual)(using ctx.fresh.setExploreTyperState()) | ||||||
| val msg = OnlyFunctionsCanBeFollowedByUnderscore(recovered.tpe.widen, tree) | ||||||
| report.errorOrMigrationWarning(msg, tree.srcPos, MigrationVersion.Scala2to3) | ||||||
| if MigrationVersion.Scala2to3.needsPatch then | ||||||
| // Under -rewrite, patch `x _` to `(() => x)` | ||||||
| msg.actions | ||||||
| .headOption | ||||||
| .foreach(Rewrites.applyAction) | ||||||
| return typed(untpd.Function(Nil, qual), pt) | ||||||
| } | ||||||
| nestedCtx.typerState.commit() | ||||||
|
|
||||||
| lazy val (prefix, suffix) = res match { | ||||||
| case Block(mdef @ DefDef(_, vparams :: Nil, _, _) :: Nil, _: Closure) => | ||||||
| val arity = vparams.length | ||||||
| if (arity > 0) ("", "") else ("(() => ", "())") | ||||||
| case _ => | ||||||
| ("(() => ", ")") | ||||||
| } | ||||||
| def remedy = | ||||||
| if ((prefix ++ suffix).isEmpty) "simply leave out the trailing ` _`" | ||||||
| else s"use `$prefix<function>$suffix` instead" | ||||||
| def rewrite = Message.rewriteNotice("This construct", `3.4-migration`) | ||||||
|
||||||
| def rewrite = Message.rewriteNotice("This construct", `3.4-migration`) | |
| def rewrite = Message.rewriteNotice("This construct", MigrationVersion.FunctionUnderscore.warnVersion) |
Contributor
There was a problem hiding this comment.
Maybe rewriteNotice should receive a MigrationVersion instead. I will check that later an refactor all the use cases if needed.
Outdated
Contributor
There was a problem hiding this comment.
This should use ExplicitContextBoundArgument. See comment bellow.
Outdated
Contributor
There was a problem hiding this comment.
This migration version should be defined in MigrationVersion.scala as ExplicitContextBoundArgument.
Outdated
Contributor
There was a problem hiding this comment.
This should use ExplicitContextBoundArgument.needsPatch. It will use 3.4-migration and check that the version is -migrating.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
There was a problem hiding this comment. Tests with warnings should now be added to
class C[T]
def foo[X: C] = ()
given [T]: C[T] = C[T]()
def Test =
foo(C[Int]()) // warn
foo(using C[Int]()) // ok |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| //> using options -Xfatal-warnings | ||
|
|
||
| class C[T] | ||
| def foo[X: C] = () | ||
|
|
||
| given [T]: C[T] = C[T]() | ||
|
|
||
| def Test = | ||
| foo(C[Int]()) // error | ||
| foo(using C[Int]()) // ok |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not convinced we should make this one a mixin. The one use case right now for
typedAsFunction, all other functions that are here and could go in here seem to be static.I would suggest making
Migrationsanobjectand redefiningTyper.typedAsFunctionasThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's nothing wrong with a mixin, and the hack of passing an explicit typer is worse. Right now it only applies tp
typedAsFunctionbut I am sure that will not stay the only one.