Don't emit line number for synthetic unit value #18717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Synthetic `()` values are added to blocks without an expression. Don't emit a line number for them. Implemented by checking the `SyntheticUnit` attachment. This seems simpler than trying to control the position assigned to synthetic unit trees, as they are created in many places.
nicolasstucki
approved these changes
Oct 18, 2023
sjrd
added
the
backport:nominated
|
For the record, I noticed that javac does in fact emit a line number for the synthetic return, see scala/scala#10577 (comment). cc @vasilmkd |
|
Thanks for the tag. I actually did not know that javac also behaves that way. Now I'm second guessing myself, if my original issue should have been opened in the first place. |
|
I think the rules for the children's game "20 questions" apply, so you are still good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synthetic
()values are added to blocks without an expression. Don't emit a line number for them.Implemented by checking the
SyntheticUnitattachment. This seems simpler than trying to control the position assigned to synthetic unit trees, as they are created in many places.Fixes #18320. Forward port of scala/scala#10577