fix regression: inline match crash when rhs uses private inlined methods #18595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bishabosha
reviewed
Sep 25, 2023
| @@ -38,6 +38,7 @@ class CompilationTests { | |||
| compileFilesInDir("tests/pos-custom-args/captures", defaultOptions.and("-language:experimental.captureChecking")), | |||
| compileFile("tests/pos-special/utf8encoded.scala", defaultOptions.and("-encoding", "UTF8")), | |||
| compileFile("tests/pos-special/utf16encoded.scala", defaultOptions.and("-encoding", "UTF16")), | |||
| compileDir("tests/pos-special/i18589", defaultOptions.and("-Ysafe-init").without("-Ycheck:all")), | |||
There was a problem hiding this comment.
is there a reason for these special flags? maybe a comment would help
There was a problem hiding this comment.
Yeah, basically "-Ycheck-all" option causes this test to fail. But this isn't a regression caused by #18557 it seems to had been this way before. It would be nice to fix it though.
There was a problem hiding this comment.
Some positions in the tree are missing.
*** error while checking tests/pos-special/i18589/test_1.scala after phase inlining ***
assertion failed: position not set for NamedCodecPlatform.Builder[Any] # -1
of class dotty.tools.dotc.ast.Trees$TypeTree in tests/pos-special/i18589/test_1.scala
There was a problem hiding this comment.
Fair enough. Looks like it's the TypeTree in the cast in
val Builder_this: NamedCodecPlatform.Builder[Any] =
Builder_this.asInstanceOf[NamedCodecPlatform.Builder[Any]]which is unpositioned. /cc @nicolasstucki
I agree you should just find a way to ignore that. I've not seen .without("-Ycheck:all") being used before, but I'm ok with it.
dwijnand
approved these changes
Sep 26, 2023
bishabosha
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #18589