Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix i18518 #18520

Merged
merged 2 commits into from
Oct 1, 2023
Merged

Fix i18518 #18520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08376a5
Reject capturing function type in polymorphic functions
Linyxus Sep 6, 2023
bb1f028
Document the special case in `getFunction`
Linyxus Sep 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions compiler/src/dotty/tools/dotc/parsing/Parsers.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1419,6 +1419,11 @@ object Parsers {
private def getFunction(tree: Tree): Option[Function] = tree match {
case Parens(tree1) => getFunction(tree1)
case Block(Nil, tree1) => getFunction(tree1)
case Function(_, _: CapturesAndResult) =>
// A function tree like this will be desugared
// into a capturing type in the typer,
// so None is returned.
None
case t: Function => Some(t)
case _ => None
}
Expand Down
5 changes: 5 additions & 0 deletions tests/neg-custom-args/captures/i18518.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
import language.experimental.captureChecking
type Foo1 = [R] -> (x: Unit) ->{} Unit // error
type Foo2 = [R] -> (x: Unit) ->{cap} Unit // error
type Foo3 = (c: Int^) -> [R] -> (x: Unit) ->{c} Unit // error
type Foo4 = (c: Int^) -> [R] -> (x0: Unit) -> (x: Unit) ->{c} Unit
Loading