Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport "Refine infoDependsOnPrefix" #18410

Merged
merged 2 commits into from
Aug 22, 2023
Merged

Backport "Refine infoDependsOnPrefix" #18410

merged 2 commits into from
Aug 22, 2023

Conversation

Kordyjan
Copy link
Contributor

Backports #18204

@odersky @Kordyjan
Refine infoDependsOnPrefix
8e9b718 
infoDependsOnPrefix now also considers non-final term members. Before
8d65f19 it only considered abstract types. Constructors were classified
as non-final, which caused regression. We now exclude constructors
specifically. Maybe we should instead classify them as effectively final.

Fixes #18160
@odersky @Kordyjan
Make constructors effectively final
d2a0b3c 
This is mainly a cleanup.
@Kordyjan Kordyjan added this to the 3.3.1 milestone Aug 16, 2023
@Kordyjan Kordyjan mentioned this pull request Aug 22, 2023
Closed
15 tasks
@Kordyjan Kordyjan merged commit f5fc096 into release-3.3.1 Aug 22, 2023
33 checks passed
@Kordyjan Kordyjan deleted the backport-18204 branch August 22, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prolativ prolativ prolativ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.3.1
Development

Successfully merging this pull request may close these issues.
3 participants
@Kordyjan @prolativ @odersky