Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't check bounds of Java applications in Java units #18054

Merged
merged 2 commits into from
Jun 26, 2023
Merged

Don't check bounds of Java applications in Java units #18054

merged 2 commits into from
Jun 26, 2023

Commits on Jun 25, 2023

  1. Don't check bounds of Java applications in Java units 

    Something goes wrong when we try to do mutually recursive F-bounds checking in Java units.
I am not sure what exactly. But in any case, Scala should not try to do Java's typechecking.
So we now check applications in Java units only if they refer to Scala classes.

I added a test for scala#7494, which was originally addressed by scala#9370, the PR which introduced the Java bounds
checking. Adding the test ensures that the new restrictions still glag the original error.

Fixes scala#17763
    @odersky
    odersky committed Jun 25, 2023
    Configuration menu
    Copy the full SHA
    5948a8c View commit details
    Browse the repository at this point in the history

  2. Drop interop test 

    For some reason it does not work with the testing farmework we have. Java sources cannot
find Scala artifacts when compiled in pass 2 with javac.
    @odersky
    odersky committed Jun 25, 2023
    Configuration menu
    Copy the full SHA
    f3d63f0 View commit details
    Browse the repository at this point in the history