Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ClassfileParser: allow missing param names (for JDK 21) #17536

Merged
merged 1 commit into from
May 22, 2023
Merged

ClassfileParser: allow missing param names (for JDK 21) #17536

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions compiler/src/dotty/tools/dotc/core/classfile/ClassfileParser.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -758,10 +758,12 @@ class ClassfileParser(
case tpnme.MethodParametersATTR =>
val paramCount = in.nextByte
for i <- 0 until paramCount do
val name = pool.getName(in.nextChar)
val index = in.nextChar
val flags = in.nextChar
if (flags & JAVA_ACC_SYNTHETIC) == 0 then
res.namedParams += (i -> name.name)
if index != 0 then
val name = pool.getName(index)
if (flags & JAVA_ACC_SYNTHETIC) == 0 then
res.namedParams += (i -> name.name)

case tpnme.AnnotationDefaultATTR =>
sym.addAnnotation(Annotation(defn.AnnotationDefaultAnnot, Nil, sym.span))
Expand Down