-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch indentation when removing braces (and other bug fixes in -indent -rewrite
)
#17522
Open
adpi2
wants to merge
9
commits into
scala:main
Choose a base branch
from
adpi2:insert-indent
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on May 30, 2023
-
Configuration menu - View commit details
-
Copy full SHA for d5a7131 - Browse repository at this point
Copy the full SHA d5a7131View commit details
Commits on Jun 13, 2023
-
Patch indentation when removing braces (essentials)
If the first indentation of the region is greater than the indentation of the enclosing region, we use it to indent the whole region. Otherwise we use the incremented indentation of the enclosing region. ```scala def foo = { x // we replicate indentation of x downward in region y } ``` ```scala def foo = { x // indentation of x is incorrect, we increment enclosing indentation y } ``` A bigger indentation than the required one is permitted except just after a closing brace. ```scala def bar = { x .toString // permitted indentation def foo = { } bar // must be unindented, to not fall into the body of foo } ``` And other bug fixes (see lampepfl#17522)
Configuration menu - View commit details
-
Copy full SHA for c6afb38 - Browse repository at this point
Copy the full SHA c6afb38View commit details -
Configuration menu - View commit details
-
Copy full SHA for de08ae0 - Browse repository at this point
Copy the full SHA de08ae0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5657b69 - Browse repository at this point
Copy the full SHA 5657b69View commit details
Commits on Jun 19, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 351b5f5 - Browse repository at this point
Copy the full SHA 351b5f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for a0d28a3 - Browse repository at this point
Copy the full SHA a0d28a3View commit details
Commits on Jul 5, 2023
-
Configuration menu - View commit details
-
Copy full SHA for d30ab4d - Browse repository at this point
Copy the full SHA d30ab4dView commit details -
Configuration menu - View commit details
-
Copy full SHA for de76335 - Browse repository at this point
Copy the full SHA de76335View commit details -
We cannot remove braces after a new line, to prevent from removing braces in stat seq.
Configuration menu - View commit details
-
Copy full SHA for f4b91e3 - Browse repository at this point
Copy the full SHA f4b91e3View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.