Avoid forcing ctors & parents which caused cycles #17086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to go back, see if we can make class completion defer completing the constructor, now that #16664 is in. |
dwijnand
changed the title
dwijnand
force-pushed
the
cyclic-namer
branch
2 times, most recently
from
dfea49c
to
a4a87b0
Compare
|
Added comments to the changes and added detail to the PR description. |
SethTisue
reviewed
Jun 20, 2024
|
@odersky Can I do anything to assist in reviewing and merging this? |
odersky
reviewed
Aug 8, 2024
There was a problem hiding this comment.
It's difficult for me to review this because the change set is large and the issues are very subtle. Would it be possible to split this in two commits? The first commit should only refactor things and move code around (it seems there's quite a bit of that). The second commit should then change the logic.
|
Yep absolutely. |
odersky
approved these changes
Aug 10, 2024
|
Thank you Martin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15177
The current class completion eagerly completes the constructor before finishing. This means that any reference within the constructor that ends up referencing that class would fail as "cyclic" even though the actual classes aren't cyclic. With the change in #16664 "Disallow constructor params from appearing in parent types for soundness", I thought perhaps that was the motivation for the completion, so with that motivation going away we could fix this code. It turns out that DerivedFromParamTree perhaps was at the centre of this. Without changing that scheme, I allowed for the necessary indexing to occur on the constructor for successful compilation, deferring the rest of the constructor completion for later.
It seems this has impacted a number of users, it used to work in Scala 2, and there's nothing wrong with it compiling, so I think we find a way to make it.