Add reflect defn.FunctionClass overloads
#16849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
fix-16847-a
branch
from
46ceada
to
3330b74
Compare
nicolasstucki
commented
Feb 8, 2023
nicolasstucki
force-pushed
the
fix-16847-a
branch
from
3330b74
to
262a4b9
Compare
smarter
reviewed
Feb 13, 2023
nicolasstucki
force-pushed
the
fix-16847-a
branch
2 times, most recently
from
230bc4a
to
ce8e6c7
Compare
nicolasstucki
changed the title
defn.{FunctionClass,ContextFunctionClass}defn.FunctionClass
nicolasstucki
changed the title
defn.FunctionClassdefn.FunctionClass overloads
smarter
requested changes
Feb 15, 2023
The old `FunctionClass` will need to be deprecated as we will remove `ErasedFunctionN` and `ErasedContextFunctionN`. We will replace this API with a simpler version that can return `FunctionN` or `ContextFunctionN`, the only two stable function classes we have in the compiler/TASTy. Other new function classes will be encoded with the more general refined function type encoding, generalization of the `PolyFunction` encoding. This implies that we won't need to add other kind of function classes to the reflect API. Part of the fix for scala#16847
nicolasstucki
force-pushed
the
fix-16847-a
branch
from
ce8e6c7
to
9571b42
Compare
smarter
approved these changes
Feb 15, 2023
This was referenced Aug 29, 2023
14 tasks
Kordyjan
added a commit
that referenced
this pull request
Aug 29, 2023
nicolasstucki
added a commit
that referenced
this pull request
Aug 30, 2023
Also, make two new constructors no longer experimental. Followup to #16849
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old
FunctionClasswill need to be deprecated as we will removeErasedFunctionNandErasedContextFunctionN. We will replace this API with a simpler version that can returnFunctionNorContextFunctionN, the only two stable function classes we have in the compiler/TASTy.Other new function classes will be encoded with the more general refined function type encoding, generalization of the
PolyFunctionencoding. This implies that we won't need to add other kind of function classes to the reflect API.Part of the fix for #16847