Handle binding of beta reduced inlined lambdas #16377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
fix-#16374
branch
5 times, most recently
from
f693e22
to
63c34cd
Compare
Handle all inline beta-reduction in the InlineReducer. All these applications will contain `Inlined` nodes that need to be handled without changing the nestedness of expressions in inlining scopes. Fixes scala#16374
nicolasstucki
force-pushed
the
fix-#16374
branch
from
63c34cd
to
4fded25
Compare
smarter
approved these changes
Nov 22, 2022
| case Inlined(call, bindings, expr) if bindings.forall(isPureBinding) => | ||
| recur(expr).map(cpy.Inlined(cl)(call, bindings, _)) | ||
| case Typed(expr, tpt) => | ||
| recur(expr) |
There was a problem hiding this comment.
Any reason we don't preserve the Typed node here?
Suggested change
| recur(expr) | |
| recur(expr).map(cpy.Typed(cl)(_, tpt)) |
There was a problem hiding this comment.
It is intentional. This ascription is on the lambda and hence has the lambda type, but the result of this transformation has the type of the result of this lambda. Dropping it is the simplest option. We could attempt to add the ascription again on the result. This would be more complicated and would also prevent optimizations on constants. We also do the same in https://github.com/lampepfl/dotty/blob/main/compiler/src/dotty/tools/dotc/transform/BetaReduce.scala#L57-L58.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle all inline beta-reduction in the InlineReducer. All these
applications will contain
Inlinednodes that need to be handledwithout changing the nestedness of expressions in inlining scopes.
Fixes #16374