Fix calculation to drop transparent classes #16344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two fixes: 1. Don't forget about refinements 2. Don't dealias Fixes scala#16342 The first fix is essential for $16342. The second fix is just to keep types tidy and not open aliases needlessly. The previous incorrect version hid errors in previous regressions scala#15365 and scala#16311 which will need to be re-opened now.
This was referenced Nov 15, 2022
|
The problem here was that a case in the computation of A { type T = B } & Cthe computation would widen to |
dwijnand
approved these changes
Nov 15, 2022
Don't drop transparent classes. This means that a type such as
```
Any { type T = A } & Object
```
will be kept as is. Previously it was reduced to `Any { type T = A }`
but that feels wrong.
Transparent classes now only enter the picture for typing union types. If the
join of a union types consists only of transparent traits or classes, keep it
instead of widening it.
This was referenced Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two fixes:
Fixes #16342
Fixes #16338
The first fix is essential for #16342. The second fix is just to keep types tidy and not open aliases needlessly.
It probably fixes issues #16337 and #16336 as well, but the test cases were not self-contained, so I could not try them out. It might fix other recent regressions as well.
The previous incorrect version hid errors in previous regressions #15365 and #16311 which will need to be re-opened now.