Fix invented names causing incorrect spans in semanticdb #11805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
There needs to be a rebase and the expect files need to be updated because of #11838 |
bishabosha
approved these changes
Mar 23, 2021
Member
bishabosha
left a comment
bishabosha
left a comment
There was a problem hiding this comment.
LGTM apart from needing the rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11692.
Anonymous given instances and anonymous given aliases have their names invented during the desugaring. Those names are not treated as being synthetic neither they are present in sources. This results in incorrect spans being assigned to them, which is a problem for tools that are using semanticdb. This pr fixes that problem by comparing name spans with corresponding spans in sources. Other parts of the compiler can still call
NamedDefTree#nameSpanand get an incorrect result.I've tried to solve that problem without reading sources, by adding abstract
def hasNamePresentInSource: BooleantoNamedDefTree, so it can be used innameSpanmethod and fix this problem globally. It turned out that this method cannot be correctly implemented forDefDefs and some anonymous given aliases are desugared to defs, so this approach was not successful. If we really want to solve this problem globally we will need to add some attachment during desugaring.