fix #10122: check parent types of references and types of parameters #10126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
reviewed
Oct 30, 2020
| tree match | ||
| case ddef: DefDef => | ||
| for | ||
| vparams <- ddef.vparamss |
There was a problem hiding this comment.
RefChecks already traverses trees, can we check things at the point where we're traversing them instead of retraversing them here? This is what scala 2 does (see checkUndesiredProperties)
There was a problem hiding this comment.
yes thank you I will try that, the reverse order is annoying for module definitions
There was a problem hiding this comment.
following discussion at the dotty meeting this will need to be done at the same place we issue deprecation warnings, as scalac reports violations of compileTimeOnly for type aliases.
Possibly follow what is described in #9825 (comment)
|
original issue was closed, so this is not a fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in scala 2 it seems the types of parameters and valdef results is also checked