-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spurious unused warning of local given for CanEqual with -Wunused:locals and -language:strictEquality #17762
Comments
I would like to remark that something similar happens when using object OneModule:
import AnotherModule.given
def meep = Meep("meep") == Meep("moop")
final case class Meep(moop: String)
object AnotherModule:
given CanEqual[Meep, Meep] = CanEqual.derived Or is this / should this be another bug? |
Also observed the same issue. Created a minimal repo (before I spotted the issue was already raised) showing the compilation failure for both:
Thanks (agree with the earlier sentiment that 3.3 is great - thanks for the improvements!) |
Hey! Getting hit by the same issue here but with |
Nice! Is this targeted to be released in 3.3.2? |
Yes. |
3.3 is awesome, thank you for bringing warnings back and all your hard work! ❤️
There seems to be a small interaction problem with what is regarded unused and
-language:strictEquality
though:Compiler version
3.3.0
Minimized code
CompilerOptions:
Output
A warning that the
given
definition is unused - or a compiler error thatSomeType
can not be compare with itself when removedExpectation
It should not warn since the
given CanEqual[...]
is required by the compiler under-language:strictEquality
Scastie
https://scastie.scala-lang.org/i6Osmdc1SSK9FQlN3a65dA
The text was updated successfully, but these errors were encountered: