Add support for Scala Native 0.4 #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolgab
force-pushed
the
support-scala-native
branch
7 times, most recently
from
a8fd9c9 to
079be9c
Compare
|
I don't know Scala Native stuff, but this looks fine to me for merge after rebase 🤷 @lolgab do you feel there is any need for additional review here? |
lolgab
force-pushed
the
support-scala-native
branch
from
217c467 to
c805f48
Compare
|
@SethTisue It sounds right to me and the tests pass, but let's ask @WojciechMazur if he can :) |
lolgab
force-pushed
the
support-scala-native
branch
from
c805f48 to
047e953
Compare
sjrd
reviewed
Jan 29, 2021
Co-authored-by: Sébastien Doeraene <[email protected]>
sjrd
approved these changes
Jan 29, 2021
|
Would it be hard to also update the CircleCI config? I don't really know where we stand with CircleCI. @ashawley added it as "experiment" and "backup" at #324 Personally, I'm fine with Travis-CI, or perhaps GitHub Actions in the future. Normally having two CI systems around doesn't really cost us anything.... except times when it does, like now. Or perhaps it would actually be simple to update? |
lolgab
force-pushed
the
support-scala-native
branch
from
7b7f3a3 to
e5f4e51
Compare
|
@SethTisue Added a CircleCI job to test on Scala Native |
|
thank you!! |
6 tasks
|
as for publishing it, #484 |
xuwei-k
reviewed
Dec 31, 2021
| @@ -0,0 +1 @@ | |||
| version = "2.7.4" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #282